Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multi chain asset list #12431

Merged
merged 110 commits into from
Dec 10, 2024
Merged

feat: multi chain asset list #12431

merged 110 commits into from
Dec 10, 2024

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Nov 26, 2024

Description

This PR introduces the Unified Asset List feature to MetaMask Mobile, providing users with a consolidated view of their assets across all supported blockchain networks. This enhancement improves the user experience by eliminating the need to switch between networks to view or manage assets, making asset management more intuitive and efficient.

We will followup with a PR to fix TS feedback we had!
(Not only TS issues but also [this](#12431 (comment) and this)

Related issues

Fixes: #12462

Manual testing steps

Build using PORTFOLIO_VIEW flag

PORTFOLIO_VIEW=true yarn watch
yarn start:ios 
yarn start:android
  1. Go to the wallet page
  2. Select all network on the network filter
  3. Check the list of assets
  4. Click on each asset with the network filter on "All Networks" and "Current Network"
  5. Test send/swap flows with testnet networks to confirm everything still works
  6. Importing all tokens should work when "All Networks" filter is on
  7. Importing networks for a specific network should work when the "Current Network" filter is on
  8. Aggregated balance should chance according to the network filter

Screenshots/Recordings

Before After
before after

Before

before_screenshot

After

after_screenshot

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward added No QA Needed Apply this label when your PR does not need any QA effort. team-assets No E2E Smoke Needed If the PR does not need E2E smoke test run team-wallet-ux labels Nov 26, 2024
@vinnyhoward vinnyhoward requested review from a team as code owners November 26, 2024 15:11
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward added the portfolio-view Used for PRs and issues related to Q4 2024 portfolio view label Nov 26, 2024
@vinnyhoward vinnyhoward requested review from a team as code owners November 27, 2024 03:56
@sahar-fehri
Copy link
Contributor

Thanks @tommasini again 🙏 we will address your TS feedback on a followup PR 🙏

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 10, 2024
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 53f5c05
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ce20a5d1-7cae-489b-a777-446f2d424ed4

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 10, 2024
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 4d480f7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1e04e7f3-44e3-4ff1-b8b9-56bf970c7f64

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 10, 2024
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 4d480f7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ddef39d6-0009-45cc-95ea-f9391ddaf11d

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@metamaskbot
Copy link
Collaborator

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4d480f7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ddef39d6-0009-45cc-95ea-f9391ddaf11d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 10, 2024
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: d1d239e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/48684b44-b3c9-4b76-8f03-31afefee8284

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@metamaskbot
Copy link
Collaborator

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d1d239e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/48684b44-b3c9-4b76-8f03-31afefee8284

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! can we add the follow up steps at the PR description?

Copy link
Contributor

@Matt561 Matt561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of the staking team!

Copy link

sonarcloud bot commented Dec 10, 2024

@vinnyhoward vinnyhoward added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 800d116 Dec 10, 2024
36 checks passed
@vinnyhoward vinnyhoward deleted the feat-multichain-list branch December 10, 2024 17:33
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
portfolio-view Used for PRs and issues related to Q4 2024 portfolio view release-7.38.0 Issue or pull request that will be included in release 7.38.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets team-wallet-ux
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Mobile: Portfolio View: Update activity list copy on Token Details